Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): upgrade to 20.18.1, latest stable in v20 #10558

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

rafaelromcar-parabol
Copy link
Contributor

Description

Upgrades node to latest stable in v20 to get the updated Docker images.

@rafaelromcar-parabol
Copy link
Contributor Author

@Dschoordsch should I upgrade too the "@types/node": "^20.11.17" to "@types/node": "^20.18.1"? Last time we ugpraded Node, that wasn't on the PR, but just to be sure.

@Dschoordsch
Copy link
Contributor

Updating @types packages to match the library is nice so we can typecheck correctly. It has no runtime implications.

@github-actions github-actions bot added size/s and removed size/xs labels Dec 9, 2024
@rafaelromcar-parabol
Copy link
Contributor Author

@Dschoordsch We can't upgrade to the same version, as there is no such tag, but I just upgraded to 20.14.8.

That upgraded the yarn.lock too. Please review and let me know if that's good to merge!

@rafaelromcar-parabol rafaelromcar-parabol merged commit 6061003 into master Dec 9, 2024
6 checks passed
@rafaelromcar-parabol rafaelromcar-parabol deleted the chore/upgrade-to-node-20.18.1 branch December 9, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants